Skip to content

Fix error when Stream is closed after container stopped#608

Merged
asvetlov merged 2 commits intoaio-libs:masterfrom
romasku:master
Jul 23, 2021
Merged

Fix error when Stream is closed after container stopped#608
asvetlov merged 2 commits intoaio-libs:masterfrom
romasku:master

Conversation

@romasku
Copy link
Copy Markdown
Contributor

@romasku romasku commented Jul 22, 2021

Follow up to #605 -- there was an issue when connector of an ClientResponse is closed before we close the response object.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the changes folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Copy link
Copy Markdown
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asvetlov asvetlov merged commit 72c1573 into aio-libs:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants