Skip to content

ssl_context not used #536

@mde-pach

Description

@mde-pach

Long story short

The ssl_context given as parameter to the Docker class is never used so you need to give a aiohttp Connector object instead of ssl_context.

Expected behaviour:

Don't have the way to give a ssl_context in Docker constructor (and be forced to use the connector parameter to pass SSL config)
OR
Use the ssl_context parameter to internaly create the connector

Actual behaviour:

ssl_context parameter is useless and we need to pass through the connector parameter to pass SSL config.

How to reproduce

import aiodocker

aiodocker.Docker(ssl_context="will work because not used")

Please explain the expected behavior so I can make a PR to fix this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions