Merged
Conversation
5fd7f24 to
4dd588b
Compare
Author
|
I pushed some extra changes in the readme, this should be as close as I can get it. @adlio curious to your thoughts :). |
Owner
|
@pubkraal I'm into the iterative approach. Reviewing... |
adlio
reviewed
Mar 25, 2022
|
|
||
| tests := []qtnTest{ | ||
| {"public", "ta[ble", `[public].[ta[ble]`}, | ||
| {"pu[b]lic", "ta[ble", `[pu[b]]lic].[ta[ble]`}, |
Owner
There was a problem hiding this comment.
I don't use MS SQL much, and this is well into the territory of "just don't name the table that", but the imbalanced brackets looked wrong to me. I double-checked and indeed this matches QUOTENAME() on MSSQL 2019. Weird.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit creates naive support for MSSQL. It works, but it doesn't support the Locker interface. The
sp_getapplockandsp_releaseapplockprocedures are a cause for a big headache, but I'm willing to into that a bit later. At least with this you can start using schema to manage your MSSQL database migrations properly.