Skip to content

feat(exempt): add new options to exempt the milestones#279

Merged
hross merged 13 commits intoactions:mainfrom
C0ZEN:feature/exempt-milestones
Jan 19, 2021
Merged

feat(exempt): add new options to exempt the milestones#279
hross merged 13 commits intoactions:mainfrom
C0ZEN:feature/exempt-milestones

Conversation

@C0ZEN
Copy link
Copy Markdown
Contributor

@C0ZEN C0ZEN commented Jan 18, 2021 •
edited
Loading

Changes:

  • Add new options exempt-milestones, exempt-issue-milestones and exempt-pr-milestones
  • Undo the changes in the lint scripts to include Prettier
    • Did not saw that some scripts were already there to run Prettier
    • Instead create new scripts to run Prettier and ESLint (which is very useful for me at least)
  • Create an Issue class to contains all the related calculated data
    • Easier to use the calculated data
    • Make more sense in OOP world IMO
  • Create an Milestones class to handle all the logic regarding the milestones
  • Fix some small spellcheck issues
  • Renamed some models/functions
    • Some models were prefixed with I since it's an interface related to a class
    • The interface is clearly in that case an API model; can keep this convention if you are ok

Closes #270.
Partially closing #272.
Partially closing #236.

C0ZEN added 12 commits November 22, 2020 10:55
@C0ZEN
Merge pull request #1 from actions/main
c21e2f2
@C0ZEN
Merge pull request #2 from actions/main
c913fa4
@C0ZEN
Merge pull request #3 from actions/main
9cf9bf2 
feat(stale-and-close): add new options to change the days before clos…
@C0ZEN
Merge pull request #4 from actions/main
f11f623
@C0ZEN
Merge pull request #5 from actions/main
0f1457a 
Remove the stale label when labeled with an exempt one  (actions#268)
@C0ZEN
Merge pull request #6 from actions/main
fef6333
@C0ZEN
feat(exempt): add new options to exempt the milestones
96cebd2 
closes actions#270
@C0ZEN
test(milestones): add coverage
b1c3ecf
@C0ZEN
test(issue): add coverage
2685c48
@C0ZEN
chore(rebase): fix all errors due to the rebase
d7fd025 
also made some changes regarding the change I made with the lint scripts and prettier. I did not saw that some scripts were already here and I created to more to keep the old ones as well
@C0ZEN
test(milestone): add coverage
029c766
@C0ZEN
chore(index): update index
95b106a
@C0ZEN
Copy link
Copy Markdown
Contributor Author

C0ZEN commented Jan 18, 2021 •
edited
Loading

@hross if you have some time left, I would love to get some help to find the culprit regarding the failing check 😢

Edit:
I think it's related to some config options being optional but yet parsed as required numbers.
Need to update a bit the code here.

Edit 2:
The culprit was indeed optional number values and was not coming from this PR.
This was due to the fact that building the index was required in order to make the checks good and up-to-date.
IMO the index build should be inside the CI and should be ignored from the repo.

@C0ZEN
fix(checks): remove checks over optional number options
f79b4db 
the code was actually handling the case where the values are NaN so it's fine
@hross hross merged commit f71123a into actions:main Jan 19, 2021
@C0ZEN C0ZEN deleted the feature/exempt-milestones branch January 19, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hross hross hross approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid stale for specific milestone(s) - Like label does

2 participants

@C0ZEN @hross