Switch cache action to use the cache node package#313
Merged
Conversation
joshmgross
approved these changes
May 15, 2020
Contributor
joshmgross
left a comment
There was a problem hiding this comment.
Awesome! Looks good to me
package.json
Outdated
| "@actions/http-client": "^1.0.8", | ||
| "@actions/io": "^1.0.1", | ||
| "uuid": "^3.3.3" | ||
| "@actions/cache": "^0.1.0" |
Contributor
There was a problem hiding this comment.
Let's make sure we publish a v1 of @actions/cache before we publish this v2 action. Would be odd if we had a major action version consume a preview package
Contributor
|
Let's add a note in the README pointing to the package in the toolkit |
Contributor
|
Well, will Zstd support be removed? |
956852b to
249a220
Compare
Contributor
Author
|
@imbsky See actions/toolkit#469 for the zstd fixes. |
Contributor
|
(I just checked the PR 🙂) |
4e389df to
e8d9126
Compare
e8d9126 to
bcc23b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Biggest change is in
setCacheState. We are now only saving cache key not the entire artifact cache object since cacheKey what we get back fromsaveCache.