Skip to content

Handle with case issues in json.#5620

Merged
hikalkan merged 1 commit into
rel-3.2from
maliming-patch-translate
Sep 29, 2020
Merged

Handle with case issues in json.#5620
hikalkan merged 1 commit into
rel-3.2from
maliming-patch-translate

Conversation

@maliming

Copy link
Copy Markdown
Member

Resolve #5618

@maliming

maliming commented Sep 28, 2020

Copy link
Copy Markdown
Member Author

@hikalkan

Should we make culture and texts property always lowercase? We have some json files using uppercase.

{
  "Culture": "en",
  "Texts": {
    "Home": "Home",
  }
}

{
  "culture": "en",
  "texts": {
    "Home": "Home",
  }
}

@maliming maliming requested a review from hikalkan September 28, 2020 02:20
@maliming maliming added this to the 3.2-final milestone Sep 28, 2020
@hikalkan

Copy link
Copy Markdown
Member

We should make them lowercase, yes, it would be good if you can fix the Uppercase usages. But supporting both is OK to tolerate errors of other developers.

@hikalkan hikalkan merged commit c124620 into rel-3.2 Sep 29, 2020
@hikalkan hikalkan deleted the maliming-patch-translate branch September 29, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants