Skip to content

feat: french localization#5494

Merged
maliming merged 5 commits into
abpframework:rel-3.2from
badre429:rel-3.2
Sep 22, 2020
Merged

feat: french localization#5494
maliming merged 5 commits into
abpframework:rel-3.2from
badre429:rel-3.2

Conversation

@badre429

@badre429 badre429 commented Sep 18, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@badre429 badre429 mentioned this pull request Sep 18, 2020
Closed
@maliming

maliming commented Sep 19, 2020

Copy link
Copy Markdown
Member

hi @badre429

Could you create PR in dev branch?

@badre429

badre429 commented Sep 19, 2020

Copy link
Copy Markdown
Contributor Author

@maliming
hi if possible we need french localization for 3.2 since localization is not has no impact on behavior of rc

@maliming maliming requested a review from hikalkan September 19, 2020 11:48
@maliming maliming added this to the 3.2-final milestone Sep 21, 2020
@hikalkan

hikalkan commented Sep 22, 2020

Copy link
Copy Markdown
Member

I agree about to merge this to rel-3.2. In fact, we should always complete the localizations in the preview period.
So, thank you @badre429

@maliming it seems OK to me, can you merge, then test it?

@hikalkan hikalkan requested a review from maliming September 22, 2020 09:29
@maliming

maliming commented Sep 22, 2020

Copy link
Copy Markdown
Member

I'll test it in next RC.

@maliming maliming merged commit 2253b12 into abpframework:rel-3.2 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hikalkan hikalkan hikalkan approved these changes

@maliming maliming Awaiting requested review from maliming

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.2-final

Development

Successfully merging this pull request may close these issues.

3 participants

@badre429 @maliming @hikalkan