Merged
Conversation
`Object.entries` already returns an array. The `Array.from` may have been from earlier iterations in desiring to create a copy of an array for subsequent mutation in the `while` loop (`stack.shift()`), but since `Object.entries` creates a new array anyways, it's not necessary.
|
Size Change: -2 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Jan 10, 2021
Member
gziolo
left a comment
There was a problem hiding this comment.
Good catch! Nice to see your contribution 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously: #20693
Object.entriesalready returns an array. TheArray.frommay have been from earlier iterations in desiring to create a copy of an array for subsequent mutation in thewhileloop (stack.shift()), but sinceObject.entriescreates a new array anyways, it's not necessary.Testing Instructions: