Overlay on disabled elements, to catch events and show tooltips#27529
Merged
draganescu merged 22 commits intoWordPress:masterfrom Jan 21, 2021
Merged
Overlay on disabled elements, to catch events and show tooltips#27529draganescu merged 22 commits intoWordPress:masterfrom
draganescu merged 22 commits intoWordPress:masterfrom
Conversation
added 4 commits
November 30, 2020 22:10
…d color in order not to paste text with the selection highlight
draganescu
reviewed
Dec 7, 2020
Contributor
draganescu
left a comment
There was a problem hiding this comment.
Due to this being a change in interaction at a component level I'll also add two apropiate labels.
added 6 commits
December 8, 2020 02:47
…d - 1. get default styling (black text) 2. diff the default styling with styles of pasted element to get all nondefault styles applied to element 3. Sanitize output 4. paste the output
Contributor
|
I'm not sure if this is caused by the overlay, or an issue with the buttons inherent disabled state (if so feel free to ignore), but I don't think the appearance should change on hover if the button is disabled. |
Contributor
Author
|
Nice catch! I have checked it and this behaviour is not connected to an overlay itself. |
Contributor
|
In that case I don't think this really needs a design review since nothing has changed visually. |
Contributor
Allowing disabled buttons to display a tooltip makes a lot of sense to me. |
added 5 commits
January 13, 2021 23:05
9a84643 to
589553f
Compare
draganescu
requested changes
Jan 18, 2021
draganescu
approved these changes
Jan 21, 2021
Contributor
draganescu
left a comment
There was a problem hiding this comment.
Tested this and looks great. Code lgtm 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #27451
According to the issue #27451 - there was no mechanism for disabled elements to catch events and to display a tooltip.
I have added a layer placed above disabled elements that work as an event catcher and therefore make a tooltip work.
I wouldn't say it is a bug fix, rather a change in current behavior. In my opinion, this change would benefit UX.
How has this been tested?
Unit test added to cover this scenario.
Manual test.
Screenshots
Types of changes
Current behaviour altered
Checklist: