Fix: regex fails to capture certain langs#30
Merged
TrueBrain merged 2 commits intoTrueBrain:mainfrom Jul 14, 2022
Merged
Conversation
Languages with non alphanumeric characters (i.e. c++) would not be captured by the regex for syntax highlighting. This change moves from a positive capture (all alphanumeric characters) to a negative capture (anything that is NOT a "). This should be a more robust solution... at least until some- one invents a language with a " in the name.
TrueBrain
reviewed
Jul 13, 2022
Also adjusted the render() method to handle the arguments expected from downstream overrides
TrueBrain
approved these changes
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix that I noticed when testing various languages today:
Languages with non alphanumeric characters (i.e. c++)
would not be captured by the regex for syntax highlighting.
This change moves from a positive capture (all alphanumeric
characters) to a negative capture (anything that is NOT a ").
This should be a more robust solution... at least until some-
one invents a language with a " in the name.