Skip to content

Fix compatibility with Node.js >= 10.0.0#73

Closed
lpinca wants to merge 3 commits intoTooTallNate:masterfrom
lpinca:support/node-10
Closed

Fix compatibility with Node.js >= 10.0.0#73
lpinca wants to merge 3 commits intoTooTallNate:masterfrom
lpinca:support/node-10

Conversation

@lpinca
Copy link
Contributor

@lpinca lpinca commented Jul 26, 2019

Resume the socket after the 'socket' event is emitted on the
ClientRequest object.

Refs: nodejs/node#24474 (comment)
Fixes: #58

lpinca added 3 commits July 26, 2019 16:30
Node.js < 4.5.0 is no longer supported as per
TooTallNate@a2779222.
Resume the socket after the `'socket'` event is emitted on the
`ClientRequest` object.

Refs: nodejs/node#24474 (comment)
Fixes: TooTallNate#58
@lpinca
Copy link
Contributor Author

lpinca commented Jul 26, 2019

Depends on TooTallNate/proxy#14.

@lpinca
Copy link
Contributor Author

lpinca commented Aug 31, 2019

@TooTallNate @sadasant ping. Are you interested in this?

TooTallNate added a commit that referenced this pull request Oct 4, 2019
Resume the socket after the `'socket'` event is emitted on the
`ClientRequest` object.

Fixes: #58
Refs: nodejs/node#24474 (comment)
@TooTallNate
Copy link
Owner

Thanks @ianhowe76!

@TooTallNate TooTallNate closed this Oct 4, 2019
@lpinca lpinca deleted the support/node-10 branch October 4, 2019 05:38
@lpinca
Copy link
Contributor Author

lpinca commented Oct 4, 2019

@TooTallNate thanks, can you cut a new release when you can?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants