Read scope from rule json metadata file.#252
Merged
Conversation
saberduck
requested changes
Aug 18, 2022
commons/src/test/java/org/sonarsource/analyzer/commons/RuleMetadataLoaderTest.java
Outdated
Show resolved
Hide resolved
| RuleScope scope; | ||
|
|
||
| assertThat(RuleMetadataLoader.getScopeIfPresent(Collections.emptyMap(), "scope")).isNotPresent(); | ||
| assertThat(RuleMetadataLoader.getScopeIfPresent(Collections.singletonMap("scope", null), "scope")).isNotPresent(); |
Contributor
There was a problem hiding this comment.
Use static import for singletonMap and emptyMap to make code a bit more succint
Contributor
Author
There was a problem hiding this comment.
Indeed I saw that too. The PR doesn't show that the same methods are used many times in the same file. There's undoubtedly an opportunity to refactor the class, for instance, to use the shorter form List.of(). I may do this as part of a separate PR, maybe? WDYT?
Contributor
There was a problem hiding this comment.
we would need to change the pom.xml to use Java 11, otherwise List.of is not available. We could do this, but perhaps later.
|
SonarQube Quality Gate
|
saberduck
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #252