Remove tests directory from package#589
Merged
mpenkov merged 1 commit intopiskvorky:developfrom Mar 5, 2021
Merged
Conversation
3 tasks
Collaborator
|
Merged. Thank you @e-nalepa and congrats on your first contribution to smart_open! |
Owner
|
Doesn't the MANIFEST file need adjustments, too? |
mpenkov
added a commit
that referenced
this pull request
Mar 5, 2021
Collaborator
|
Good point @piskvorky . Following up in #591. |
mpenkov
added a commit
that referenced
this pull request
Mar 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #588
This PR removes
testsdirectory from package, and so reduces the size of the package by 60%.(Keeping a small package size is important when using a package on AWS Lambda).
No new test is added, I checked the following points:
testsdirectory is not any more present after a$ pip installBefore you create the PR, please make sure you have: