Change download_as_string to download_as_bytes in gcs submodule#571
Merged
mpenkov merged 2 commits intopiskvorky:developfrom Dec 30, 2020
Merged
Change download_as_string to download_as_bytes in gcs submodule#571mpenkov merged 2 commits intopiskvorky:developfrom
mpenkov merged 2 commits intopiskvorky:developfrom
Conversation
Owner
|
Thanks Alexandre, much appreciated. CC @petedannemann – can you review please? |
Contributor
|
LGTM! Nice work. Very odd that Google decided to make this fix to |
Contributor
|
I am confused about how coveralls is reporting that this change caused our test coverage to drop by 5.5% |
Collaborator
|
I think the drop in coverage is entirely unrelated to this PR. I'm rolling out a github actions workflow to do the building and testing. Right now it's running parallel to Travis CI. I think it may be affecting the coveralls results. |
Collaborator
|
Merged! Thank you for the contribution, and congrats on your first smart_open PR @alexandreyc ! 🍾 |
Contributor
Author
|
Thank you all! |
alexandreyc
commented
Dec 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
According to the documentation of
download_as_string, this method is being deprecated in favor of its aliasdownload_as_bytes.Here is a PR that update the related code. I also updated some broken links to the official documentation.
Alexandre