Skip to content

Improve file mode handling#559

Merged
mpenkov merged 5 commits intodevelopfrom
fix_gzip_text
Nov 20, 2020
Merged

Improve file mode handling#559
mpenkov merged 5 commits intodevelopfrom
fix_gzip_text

Conversation

@mpenkov
Copy link
Copy Markdown
Collaborator

@mpenkov mpenkov commented Nov 17, 2020

Make it more robust to the arbitrary character ordering.

Fix #556

Make it more robust to the arbitrary character ordering.

Fix #556
@mpenkov mpenkov marked this pull request as draft November 17, 2020 03:25
@mpenkov mpenkov marked this pull request as ready for review November 18, 2020 06:47
@mpenkov mpenkov requested a review from piskvorky November 18, 2020 23:59
@mpenkov
Copy link
Copy Markdown
Collaborator Author

mpenkov commented Nov 19, 2020

I disabled the HTTP tests because they seem to be failing on Travis now. Will investigate separately.

Comment thread smart_open/smart_open_lib.py
Comment thread smart_open/tests/test_smart_open.py Outdated
Comment thread smart_open/smart_open_lib.py
Comment thread smart_open/tests/test_smart_open.py Outdated
@mpenkov mpenkov merged commit db14442 into develop Nov 20, 2020
@mpenkov mpenkov deleted the fix_gzip_text branch November 20, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ValueError when attempting to read/write gzip files using rt/wt mode

2 participants