fix signature in callbacks to prevent deprecation warning#9347
Merged
lexierule merged 5 commits intorelease/1.4.xfrom Sep 7, 2021
Merged
fix signature in callbacks to prevent deprecation warning#9347lexierule merged 5 commits intorelease/1.4.xfrom
lexierule merged 5 commits intorelease/1.4.xfrom
Conversation
awaelchli
commented
Sep 6, 2021
carmocca
approved these changes
Sep 6, 2021
Codecov Report
@@ Coverage Diff @@
## release/1.4.x #9347 +/- ##
=============================================
Coverage 92% 92%
=============================================
Files 218 218
Lines 14490 14490
=============================================
Hits 13393 13393
Misses 1097 1097 |
ethanwharris
approved these changes
Sep 7, 2021
kaushikb11
approved these changes
Sep 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9346
Reproducible only on the 1.4.x branch.
On master, the issue is already fixed by #8587. However, since that change was not a bugfix and will not be merged back to 1.4.x, I'm submitting this hotfix here as a standalone PR.
The warning appears because "args" is in the signature of the method and this matches the deprecated ones.
This should go before the 1.4.6 patch release.
Repro:
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃