Skip to content

Fix module dict in base finetuning#8170

Merged
ethanwharris merged 2 commits intomasterfrom
bugfix/base_finetuning
Jun 28, 2021
Merged

Fix module dict in base finetuning#8170
ethanwharris merged 2 commits intomasterfrom
bugfix/base_finetuning

Conversation

@ethanwharris
Copy link
Copy Markdown
Member

@ethanwharris ethanwharris commented Jun 28, 2021 •
edited
Loading

What does this PR do?

Fixes #8169

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 28, 2021 •
edited
Loading

Codecov Report

Merging #8170 (7c25367) into master (c3065c5) will decrease coverage by 5%.
The diff coverage is 67%.

@@           Coverage Diff           @@
##           master   #8170    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         211     211            
  Lines       13440   13442     +2     
=======================================
- Hits        12450   11832   -618     
- Misses        990    1610   +620

tchaton
tchaton approved these changes Jun 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

kaushikb11
kaushikb11 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would suggest adding ModuleDict to the type hint for modules.

@awaelchli awaelchli added the bug Something isn't working label Jun 28, 2021
@awaelchli awaelchli added this to the v1.3.x milestone Jun 28, 2021
@ethanwharris ethanwharris enabled auto-merge (squash) June 28, 2021 10:20
@ethanwharris ethanwharris merged commit 2a372e3 into master Jun 28, 2021
@ethanwharris ethanwharris deleted the bugfix/base_finetuning branch June 28, 2021 10:55
awaelchli added a commit that referenced this pull request Jun 29, 2021
@awaelchli
Fix module dict in base finetuning (#8170)
53219ae 
* Fix module dict in base finetuning

* Update CHANGELOG.md
awaelchli added a commit that referenced this pull request Jun 29, 2021
@awaelchli
Fix module dict in base finetuning (#8170)
bd164ee 
* Fix module dict in base finetuning

* Update CHANGELOG.md
awaelchli added a commit that referenced this pull request Jun 30, 2021
@awaelchli
Fix module dict in base finetuning (#8170)
9ead05e 
* Fix module dict in base finetuning

* Update CHANGELOG.md
awaelchli pushed a commit that referenced this pull request Jul 1, 2021
@ethanwharris @awaelchli
Fix module dict in base finetuning (#8170)
e3c5c44 
* Fix module dict in base finetuning

* Update CHANGELOG.md
lexierule pushed a commit that referenced this pull request Jul 1, 2021
@ethanwharris @lexierule
Fix module dict in base finetuning (#8170)
d317ebf 
* Fix module dict in base finetuning

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

pl:1.3.x

Development

Successfully merging this pull request may close these issues.

ModuleDict with BaseFinetuning causes recursion error

5 participants

@ethanwharris @awaelchli @Borda @tchaton @kaushikb11