Skip to content

Add LightningCLI(save_config_overwrite=False|True)#8059

Merged
carmocca merged 4 commits intomasterfrom
feat/cli-exist-ok
Jun 21, 2021
Merged

Add LightningCLI(save_config_overwrite=False|True)#8059
carmocca merged 4 commits intomasterfrom
feat/cli-exist-ok

Conversation

@carmocca
Copy link
Copy Markdown
Contributor

@carmocca carmocca commented Jun 21, 2021 •
edited
Loading

What does this PR do?

Add overwrite to SaveConfigCallback + plumbing for it
Improve error message
Add test

cc: @mauvilsa

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added feature Is an improvement or enhancement argparse (removed) Related to argument parsing (argparse, Hydra, ...) labels Jun 21, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 21, 2021
@carmocca carmocca self-assigned this Jun 21, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 21, 2021 •
edited
Loading

Codecov Report

Merging #8059 (4b6097f) into master (2303f9c) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8059   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         210     210           
  Lines       13579   13581    +2     
======================================
- Hits        12452   12416   -36     
- Misses       1127    1165   +38

@carmocca carmocca changed the title LightningCLI exist_ok Add LightningCLI(save_config_exist_ok=False|True) Jun 21, 2021
awaelchli
awaelchli approved these changes Jun 21, 2021
View reviewed changes
Comment thread pytorch_lightning/utilities/cli.py Outdated
@carmocca carmocca changed the title Add LightningCLI(save_config_exist_ok=False|True) Add LightningCLI(save_config_overwrite=False|True) Jun 21, 2021
Borda
Borda approved these changes Jun 21, 2021
View reviewed changes
Comment thread pytorch_lightning/utilities/cli.py
mauvilsa
mauvilsa approved these changes Jun 21, 2021
View reviewed changes
Comment thread pytorch_lightning/utilities/cli.py
@carmocca carmocca enabled auto-merge (squash) June 21, 2021 13:56
@carmocca carmocca added the ready to be merged PRs ready to be merged label Jun 21, 2021
@carmocca carmocca merged commit d9bf975 into master Jun 21, 2021
@carmocca carmocca deleted the feat/cli-exist-ok branch June 21, 2021 15:58
@carmocca carmocca mentioned this pull request Jun 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@mauvilsa mauvilsa mauvilsa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carmocca carmocca

Labels

argparse (removed) Related to argument parsing (argparse, Hydra, ...) feature Is an improvement or enhancement ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.4

Development

Successfully merging this pull request may close these issues.

5 participants

@carmocca @awaelchli @mauvilsa @Borda @justusschock