Conversation
added 30 commits
February 22, 2021 17:10
# Conflicts: # pytorch_lightning/trainer/connectors/accelerator_connector.py
added 10 commits
June 9, 2021 12:47
kaushikb11
reviewed
Jun 11, 2021
kaushikb11
reviewed
Jun 11, 2021
kaushikb11
reviewed
Jun 11, 2021
kaushikb11
reviewed
Jun 11, 2021
kaushikb11
reviewed
Jun 11, 2021
tchaton
approved these changes
Jun 11, 2021
awaelchli
approved these changes
Jun 11, 2021
Contributor
awaelchli
left a comment
There was a problem hiding this comment.
will it impact coverage? maybe better to exclude the files for now until we run it also on the IPU CI?
Contributor
|
@SeanNaren and Graphcore team, really nice work |
kaushikb11
reviewed
Jun 11, 2021
added 2 commits
June 11, 2021 15:24
speediedan
pushed a commit
to speediedan/lightning
that referenced
this pull request
Jun 11, 2021
* Initial changes * Add broken example for now * Fix reference * Fix format * Code runs * Fixes * Clear up files * Add tests, helpers, fixes * Small cleanups * Refactors based on review * Swap to special tests * Add special tests * Add source * Cleanups * Add logic to attach/detach model from devices * Fixes for tests * Fixes for tests * Move earlier * Cleanups * Add check for nvcc * Add tests, cleanups * Fix errors * fix * Try condition * Add missing annotation * Clearer * Clearer message * Fix variable * Cleanups * Add comment * CHANGELOG.md * Add simple selection test * Remove special=True to see what happens * Fix test * Update tests/accelerators/test_ipu.py Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com> * Convert ipu_cores -> ipus * Add typing, fail earlier * simplify precision * Add test, add helper * fix accum * Update pytorch_lightning/plugins/training_type/ipu.py Co-authored-by: thomas chaton <thomas@grid.ai> * Use stages * Make sure warning message returned * thorw error * Add more tests, use fs * add comment * Clean * Address feedback, add IPU tests * Fixes * Fix signature * Add types * Remove autoround * Add docstring * ipu_cores -> ipus * Add test, remove unnecessary precision set * Add optimizer test * Add precision back with test * Address code review * Change to probs * Move some of the asserts earlier Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com> Co-authored-by: thomas chaton <thomas@grid.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the IPU Accelerator to PyTorch Lightning!
I have created a new folder called
ipu_examplesto store a simple mnist.py example, however it might be best if this moves elsewhere where we can add more examples.Overall we only support 1 optimizer, and most of the other features.
We're working with the GraphCore engineers to support logging/metrics, as they require results calculated from the device which is current unsupported. They already are working on this, and I'll make an issue for us to track
Still gives people who want to test this out something to work with if they have access to IPUs :)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃