[bugfix] Resolve LearningRateMonitor + BackboneFinetuning#7835
Merged
[bugfix] Resolve LearningRateMonitor + BackboneFinetuning#7835
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7835 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 199 202 +3
Lines 13017 13073 +56
=======================================
- Hits 12052 11480 -572
- Misses 965 1593 +628 |
awaelchli
approved these changes
Jun 4, 2021
Contributor
awaelchli
left a comment
There was a problem hiding this comment.
LGTM just minor comments
ethanwharris
approved these changes
Jun 4, 2021
Borda
reviewed
Jun 4, 2021
Collaborator
Borda
left a comment
There was a problem hiding this comment.
is it ready? I see some remaining debugging prints etc.
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
carmocca
suggested changes
Jun 6, 2021
carmocca
approved these changes
Jun 7, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Closed
SeanNaren
pushed a commit
that referenced
this pull request
Jun 8, 2021
* add test + resolve bug * update changelog * resolve bug * resolve bug * Update pytorch_lightning/callbacks/lr_monitor.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Update pytorch_lightning/callbacks/lr_monitor.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * update on comments * resolve comments * update * Update tests/callbacks/test_lr_monitor.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Update pytorch_lightning/callbacks/lr_monitor.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> (cherry picked from commit d1becce)
Borda
added a commit
that referenced
this pull request
Jun 8, 2021
* add test + resolve bug * update changelog * resolve bug * resolve bug * Update pytorch_lightning/callbacks/lr_monitor.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Update pytorch_lightning/callbacks/lr_monitor.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * update on comments * resolve comments * update * Update tests/callbacks/test_lr_monitor.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Update pytorch_lightning/callbacks/lr_monitor.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
lexierule
pushed a commit
that referenced
this pull request
Jun 9, 2021
* add test + resolve bug * update changelog * resolve bug * resolve bug * Update pytorch_lightning/callbacks/lr_monitor.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Update pytorch_lightning/callbacks/lr_monitor.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * update on comments * resolve comments * update * Update tests/callbacks/test_lr_monitor.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Update pytorch_lightning/callbacks/lr_monitor.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> (cherry picked from commit d1becce)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7830
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃