Skip to content

Add __len__ method to IndexBatchSamplerWrapper#7681

Merged
kaushikb11 merged 7 commits intoLightning-AI:masterfrom
kaushikb11:len/indexbatchsampler
May 26, 2021
Merged

Add __len__ method to IndexBatchSamplerWrapper#7681
kaushikb11 merged 7 commits intoLightning-AI:masterfrom
kaushikb11:len/indexbatchsampler

Conversation

@kaushikb11
Copy link
Copy Markdown
Contributor

@kaushikb11 kaushikb11 commented May 24, 2021 •
edited
Loading

What does this PR do?

Fixes #7664

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 self-assigned this May 24, 2021
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented May 24, 2021 •
edited
Loading

Hello @kaushikb11! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-26 15:35:05 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2021 •
edited
Loading

Codecov Report

Merging #7681 (9744e80) into master (b1a7b7e) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7681    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         199     199            
  Lines       12960   12962     +2     
=======================================
- Hits        11990   11373   -617     
- Misses        970    1589   +619

@kaushikb11 kaushikb11 added the bug Something isn't working label May 24, 2021
@kaushikb11 kaushikb11 added this to the v1.3.x milestone May 24, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review May 24, 2021 16:30
@kaushikb11 kaushikb11 changed the title Add __len__ method to IndexBatchSampler Add __len__ method to IndexBatchSamplerWrapper May 24, 2021
@kaushikb11 kaushikb11 added the priority: 0 High priority task label May 24, 2021
awaelchli
awaelchli approved these changes May 24, 2021
View reviewed changes
Comment thread tests/models/test_tpu.py Outdated
carmocca
carmocca reviewed May 24, 2021
View reviewed changes
Comment thread tests/models/test_tpu.py Outdated
Comment thread tests/models/test_tpu.py Outdated
Comment thread tests/models/test_tpu.py Outdated

@RunIf(tpu=True)
@pl_multi_process_test
def test_predict_tpu_multi_cores(tmpdir):
Copy link
Copy Markdown
Contributor

@carmocca carmocca May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an unit test would be better suited for this PR

Copy link
Copy Markdown
Contributor Author

@kaushikb11 kaushikb11 May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you have in mind? Just check the len attribute for IndexBatchSamplerWrapper?

Copy link
Copy Markdown
Contributor

@carmocca carmocca May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, simple and effective 😜

Copy link
Copy Markdown
Contributor Author

@kaushikb11 kaushikb11 May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

tchaton
tchaton approved these changes May 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! Just need to address comments

@mergify mergify Bot removed the has conflicts label May 26, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) May 26, 2021 15:35
@kaushikb11 kaushikb11 merged commit 04dcb17 into Lightning-AI:master May 26, 2021
@tchaton tchaton mentioned this pull request Jun 1, 2021
Closed
tchaton pushed a commit that referenced this pull request Jun 1, 2021
@kaushikb11 @pre-commit-ci @tchaton
Add __len__ method to IndexBatchSamplerWrapper (#7681)
ccda7d4 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
tchaton pushed a commit that referenced this pull request Jun 1, 2021
@kaushikb11 @pre-commit-ci @tchaton
Add __len__ method to IndexBatchSamplerWrapper (#7681)
b9175b7 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Borda pushed a commit that referenced this pull request Jun 1, 2021
@kaushikb11 @pre-commit-ci @Borda
Add __len__ method to IndexBatchSamplerWrapper (#7681)
78a4f0d 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
tchaton pushed a commit that referenced this pull request Jun 1, 2021
@kaushikb11 @pre-commit-ci @tchaton
Add __len__ method to IndexBatchSamplerWrapper (#7681)
2650394 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
lexierule pushed a commit that referenced this pull request Jun 1, 2021
@kaushikb11 @pre-commit-ci @lexierule
Add __len__ method to IndexBatchSamplerWrapper (#7681)
ed8d009 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@Borda Borda Awaiting requested review from Borda

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kaushikb11 kaushikb11

Labels

bug Something isn't working priority: 0 High priority task

Projects

None yet

Milestone

pl:1.3.x

Development

Successfully merging this pull request may close these issues.

Trainer.predict is not working on TPUs

5 participants

@kaushikb11 @pep8speaks @awaelchli @carmocca @tchaton