fix local rank display bug in info message#7395
Merged
justusschock merged 1 commit intomasterfrom May 10, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7395 +/- ##
=======================================
- Coverage 92% 91% -1%
=======================================
Files 200 200
Lines 12982 13340 +358
=======================================
+ Hits 11933 12163 +230
- Misses 1049 1177 +128 |
ananthsub
approved these changes
May 6, 2021
justusschock
approved these changes
May 7, 2021
s-rog
approved these changes
May 10, 2021
Closed
Borda
pushed a commit
that referenced
this pull request
May 11, 2021
(cherry picked from commit 6bc616d)
Borda
pushed a commit
that referenced
this pull request
May 11, 2021
(cherry picked from commit 6bc616d)
Borda
pushed a commit
that referenced
this pull request
May 11, 2021
(cherry picked from commit 6bc616d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a visual bug.
The env variable
LOCAL_RANKis not available in all clusters and may be named differently. To resolve this, we will refer to the cluster environment / plugin to determine that value.Reported in a discussion #7275
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃