Conversation
carmocca
reviewed
Apr 13, 2021
justusschock
approved these changes
Apr 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #6999 +/- ##
=======================================
- Coverage 92% 87% -5%
=======================================
Files 197 197
Lines 12617 12615 -2
=======================================
- Hits 11605 10997 -608
- Misses 1012 1618 +606 |
SeanNaren
approved these changes
Apr 14, 2021
awaelchli
approved these changes
Apr 14, 2021
Contributor
|
@Borda Any update on this? |
This was referenced Apr 22, 2021
Merged
kaushikb11
pushed a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
Apr 22, 2021
lexierule
pushed a commit
that referenced
this pull request
Apr 22, 2021
ananthsub
reviewed
Apr 23, 2021
Comment on lines
+57
to
+58
| pkg_version = Version(pkg.__version__) | ||
| except TypeError: |
Contributor
There was a problem hiding this comment.
@Borda this breaks if the pkg doesn't have __version__ defined. the previously caught attribute error is now raised. i'm seeing this with torchtext which doesn't seem to export the version info from source: https://github.com/pytorch/text/blob/ccebe7ced8d2229b98e39546fcfbf3e233bd70d9/torchtext/__init__.py#L10-L14
cc @parmeet
Collaborator
Author
There was a problem hiding this comment.
Well, this seems as torchtext as they import own module version which is missing... Also their git_version is gone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
resolving some compatibility issue with aplha versions
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃