Skip to content

Fix: Train loop config validation was run during trainer.predict#6541

Merged
kaushikb11 merged 7 commits intoLightning-AI:v1.2.4from
kaushikb11:fix/predict
Mar 16, 2021
Merged

Fix: Train loop config validation was run during trainer.predict#6541
kaushikb11 merged 7 commits intoLightning-AI:v1.2.4from
kaushikb11:fix/predict

Conversation

@kaushikb11
Copy link
Copy Markdown
Contributor

@kaushikb11 kaushikb11 commented Mar 15, 2021 •
edited by carmocca
Loading

What does this PR do?

Fixes:
While predicting, it was verifying the train_loop configuration.

Only necessary for the bug-fix release branch

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added this to the 1.2.x milestone Mar 15, 2021
@kaushikb11 kaushikb11 added the priority: 0 High priority task label Mar 15, 2021
carmocca
carmocca approved these changes Mar 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do you want to also open a PR to master with these changes and resolve this TODO?

https://github.com/PyTorchLightning/pytorch-lightning/blob/6a1414681107cf77d1ebeba86359df7b6668bf49/pytorch_lightning/trainer/configuration_validator.py#L43

@kaushikb11
Copy link
Copy Markdown
Contributor Author

kaushikb11 commented Mar 15, 2021

@carmocca Sure.

Wondering where should I do the Changelog update here.

Borda
Borda requested changes Mar 15, 2021
View reviewed changes
Comment thread tests/trainer/test_trainer.py Outdated
@Borda
Copy link
Copy Markdown
Collaborator

Borda commented Mar 15, 2021

Wondering where should I do the Changelog update here.

in Added section :]

@kaushikb11 kaushikb11 changed the title Add verify config for predict Fix: Train loop config validation was run during trainer.predict Mar 16, 2021
@kaushikb11 kaushikb11 mentioned this pull request Mar 16, 2021
Merged
8 tasks
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Mar 16, 2021 •
edited
Loading

Hello @kaushikb11! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-16 16:19:18 UTC

@kaushikb11
Copy link
Copy Markdown
Contributor Author

kaushikb11 commented Mar 16, 2021

@Borda Your commit won't work. dataloaders is not defined. Reverting back.

@kaushikb11 kaushikb11 self-assigned this Mar 16, 2021
@Borda
Copy link
Copy Markdown
Collaborator

Borda commented Mar 16, 2021

@Borda Your commit won't work. dataloaders is not defined. Reverting back.

it shall be defined in the parameter, right?

@Borda
Copy link
Copy Markdown
Collaborator

Borda commented Mar 16, 2021

what is the difference to #6543?

@kaushikb11 kaushikb11 changed the base branch from release/1.2.x to v1.2.4 March 16, 2021 16:15
@mergify mergify Bot removed the has conflicts label Mar 16, 2021
@kaushikb11 kaushikb11 merged commit d608911 into Lightning-AI:v1.2.4 Mar 16, 2021
@kaushikb11 kaushikb11 deleted the fix/predict branch March 16, 2021 16:19
Borda pushed a commit that referenced this pull request Mar 16, 2021
@kaushikb11 @Borda
Fix: Train loop config validation was run during trainer.predict (#…
f35b9b8 
…6541)
lexierule pushed a commit that referenced this pull request Mar 16, 2021
@kaushikb11 @lexierule
Fix: Train loop config validation was run during trainer.predict (#…
953c873 
…6541)
This was referenced Mar 17, 2021
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+1 more reviewer

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kaushikb11 kaushikb11

Labels

priority: 0 High priority task

Projects

None yet

Milestone

pl:1.2.x

Development

Successfully merging this pull request may close these issues.

5 participants

@kaushikb11 @Borda @pep8speaks @carmocca @justusschock