Skip to content

[ModelPruning] Add missing attribute with use_global_unstructured=False and verbose#6045

Merged
carmocca merged 2 commits intomasterfrom
pruning-missing-name
Feb 18, 2021
Merged

[ModelPruning] Add missing attribute with use_global_unstructured=False and verbose#6045
carmocca merged 2 commits intomasterfrom
pruning-missing-name

Conversation

@carmocca
Copy link
Copy Markdown
Contributor

@carmocca carmocca commented Feb 17, 2021

What does this PR do?

__name__ is lost with partial and this wasn't covered with the current tests because it needs verbose.

Before submitting

  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added bug Something isn't working ready to be merged PRs ready to be merged priority: 0 High priority task callback labels Feb 17, 2021
@carmocca carmocca added this to the 1.2 milestone Feb 17, 2021
@carmocca carmocca self-assigned this Feb 17, 2021
@carmocca carmocca changed the title Add __name__ to partial [ModelPruning] Add missing attribute with use_global_unstructured=False and verbose Feb 18, 2021
@carmocca carmocca enabled auto-merge (squash) February 18, 2021 00:01
@Borda
Copy link
Copy Markdown
Collaborator

Borda commented Feb 18, 2021

@carmocca "ready-to-go" is meant for the first positive reviewer, otherwise, there is no reason to use it...

@carmocca
Copy link
Copy Markdown
Contributor Author

carmocca commented Feb 18, 2021

@carmocca "ready-to-go" is meant for the first positive reviewer, otherwise, there is no reason to use it...

Well i'm positive this works 😄

Just added it because the PR is so small but I'll hold off for next time.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 18, 2021 •
edited
Loading

Codecov Report

Merging #6045 (7f911a4) into master (8440595) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #6045   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         160     160           
  Lines       11392   11402   +10     
======================================
- Hits        10607   10595   -12     
- Misses        785     807   +22

@Borda
Copy link
Copy Markdown
Collaborator

Borda commented Feb 18, 2021

there is something fishy on codecov, this minimal changes shall pass, maybe because of edited lines that are not covered by tests?

@carmocca carmocca merged commit 38ad9e0 into master Feb 18, 2021
tchaton
tchaton approved these changes Feb 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca deleted the pruning-missing-name branch February 18, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+1 more reviewer

@SeanNaren SeanNaren SeanNaren approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carmocca carmocca

Labels

bug Something isn't working callback priority: 0 High priority task ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.2

Development

Successfully merging this pull request may close these issues.

4 participants

@carmocca @Borda @SeanNaren @tchaton