Skip to content

fix/test quant#6040

Merged
Borda merged 14 commits intomasterfrom
tests/quant
Feb 18, 2021
Merged

fix/test quant#6040
Borda merged 14 commits intomasterfrom
tests/quant

Conversation

@Borda
Copy link
Copy Markdown
Collaborator

@Borda Borda commented Feb 17, 2021 •
edited
Loading

What does this PR do?

fix skip tests and add test for torchscript

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug Something isn't working label Feb 17, 2021
@Borda Borda added this to the 1.2 milestone Feb 17, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #6040 (9dc4576) into master (b7c2e0a) will increase coverage by 0%.
The diff coverage is 96%.

@@          Coverage Diff           @@
##           master   #6040   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         160     160           
  Lines       11367   11401   +34     
======================================
+ Hits        10582   10622   +40     
+ Misses        785     779    -6

@Borda Borda enabled auto-merge (squash) February 17, 2021 21:07
tchaton
tchaton approved these changes Feb 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

carmocca
carmocca reviewed Feb 17, 2021
View reviewed changes
Comment thread pytorch_lightning/utilities/imports.py Outdated
SkafteNicki
SkafteNicki approved these changes Feb 17, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :]

@Borda Borda requested a review from carmocca February 17, 2021 22:54
@Borda Borda added ci Continuous Integration ready to be merged PRs ready to be merged labels Feb 17, 2021
carmocca
carmocca reviewed Feb 17, 2021
View reviewed changes
Comment thread pytorch_lightning/callbacks/quantization.py Outdated
Comment thread pytorch_lightning/callbacks/quantization.py Outdated
@Borda Borda merged commit 049006a into master Feb 18, 2021
@Borda Borda deleted the tests/quant branch February 18, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+4 more reviewers

@SeanNaren SeanNaren SeanNaren approved these changes

@ananyahjha93 ananyahjha93 ananyahjha93 approved these changes

@carmocca carmocca carmocca approved these changes

@s-rog s-rog s-rog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working ci Continuous Integration ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.2

Development

Successfully merging this pull request may close these issues.

7 participants

@Borda @SeanNaren @ananyahjha93 @carmocca @tchaton @SkafteNicki @s-rog