Skip to content

Quantisation#5706

Merged
Borda merged 48 commits intorelease/1.2-devfrom
feat/quantization
Feb 11, 2021
Merged

Quantisation#5706
Borda merged 48 commits intorelease/1.2-devfrom
feat/quantization

Conversation

@Borda
Copy link
Copy Markdown
Collaborator

@Borda Borda commented Jan 29, 2021 •
edited
Loading

What does this PR do?

Resources:

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added feature Is an improvement or enhancement callback labels Jan 29, 2021
@Borda Borda added this to the 1.2 milestone Jan 29, 2021
@Borda Borda self-assigned this Jan 30, 2021
@Borda Borda force-pushed the feat/quantization branch from 1003083 to c659750 Compare February 1, 2021 16:05
@Borda Borda changed the title Quantization Quantisation [wip] Feb 1, 2021
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Feb 5, 2021 •
edited
Loading

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-11 11:21:09 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 5, 2021 •
edited
Loading

Codecov Report

Merging #5706 (c646e3d) into release/1.2-dev (9475c84) will decrease coverage by 0%.
The diff coverage is 71%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5706    +/-   ##
================================================
- Coverage               88%     88%    -0%     
================================================
  Files                  182     184     +2     
  Lines                13082   13191   +109     
================================================
+ Hits                 11576   11624    +48     
- Misses                1506    1567    +61

@Borda Borda marked this pull request as ready for review February 5, 2021 09:54
@Borda Borda changed the title Quantisation [wip] Quantisation Feb 5, 2021
tchaton
tchaton reviewed Feb 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and amazing new feature !

Comment thread pytorch_lightning/callbacks/quantization.py Outdated
Comment thread pytorch_lightning/callbacks/quantization.py Outdated
Comment thread pytorch_lightning/callbacks/quantization.py Outdated
Comment thread pytorch_lightning/callbacks/quantization.py Outdated
Comment thread pytorch_lightning/callbacks/quantization.py Outdated
Comment thread pytorch_lightning/callbacks/quantization.py
Comment thread pytorch_lightning/core/lightning.py
Comment thread tests/callbacks/test_quantization.py Outdated
Comment thread tests/callbacks/test_quantization.py Outdated
@Borda
Copy link
Copy Markdown
Collaborator Author

Borda commented Feb 7, 2021

fyi, moving adding the new models to #5861

@Borda Borda force-pushed the feat/quantization branch from 07c59ea to 498ee2b Compare February 7, 2021 20:53
SkafteNicki
SkafteNicki reviewed Feb 8, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mix of comments :]

Comment thread pytorch_lightning/callbacks/__init__.py
Comment thread pytorch_lightning/callbacks/quantization.py
Comment thread pytorch_lightning/callbacks/quantization.py
Comment thread pytorch_lightning/callbacks/quantization.py
Comment thread pytorch_lightning/metrics/functional/mean_relative_error.py
Comment thread pytorch_lightning/metrics/functional/mean_relative_error.py Outdated
Comment thread tests/callbacks/test_quantization.py Outdated
Comment thread pytorch_lightning/metrics/functional/mean_relative_error.py
Borda
Borda commented Feb 8, 2021
View reviewed changes
Comment thread Makefile
@Borda Borda force-pushed the feat/quantization branch from cb8dc27 to 92f8cfb Compare February 8, 2021 11:05
carmocca
carmocca reviewed Feb 8, 2021
View reviewed changes
Comment thread CHANGELOG.md Outdated
Comment thread pytorch_lightning/callbacks/quantization.py
Comment thread pytorch_lightning/callbacks/quantization.py Outdated
Comment thread pytorch_lightning/callbacks/quantization.py Outdated
Comment thread pytorch_lightning/callbacks/quantization.py Outdated
Comment thread tests/callbacks/test_pruning.py
Comment thread pytorch_lightning/metrics/functional/mean_relative_error.py
Comment thread pytorch_lightning/callbacks/quantization.py
Comment thread tests/callbacks/test_quantization.py Outdated
Comment thread tests/callbacks/test_quantization.py Outdated
Borda and others added 20 commits February 11, 2021 11:26
@Borda
dupl
2ebacf7
@Borda @SkafteNicki
Apply suggestions from code review
4be45d7 
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
@Borda @carmocca
Apply suggestions from code review
814635d 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@Borda
fixes
753853c
@Borda
gpu
d4ff9f2
@Borda @carmocca
Apply suggestions from code review
87026e7 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@Borda
.
93fb520
@Borda
.
9ce7919
@Borda
.
2bca86d
@Borda
fix
a59e74b
@Borda
fix
9a519a6
@Borda
fixes
949730d
@Borda
note
82e70c9
@Borda
.
53b8f18
@Borda
warn
b84fe5a
@Borda
45
8a432b4
@Borda @carmocca
link
6fd76ae 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@Borda
d
fcfe0ad
@Borda @carmocca
Apply suggestions from code review
abc73d3 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@Borda
yapf
17d0028
@Borda Borda force-pushed the feat/quantization branch from a9a7f51 to 1379621 Compare February 11, 2021 10:31
@mergify mergify Bot removed the has conflicts label Feb 11, 2021
Borda
Borda commented Feb 11, 2021
View reviewed changes
Comment thread Makefile Outdated
@Borda Borda disabled auto-merge February 11, 2021 11:13
@Borda Borda enabled auto-merge (squash) February 11, 2021 11:14
@Borda Borda force-pushed the feat/quantization branch from 189cd59 to b76eee5 Compare February 11, 2021 11:21
@Borda Borda merged commit b434c47 into release/1.2-dev Feb 11, 2021
@Borda Borda deleted the feat/quantization branch February 11, 2021 12:04
@carmocca carmocca mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@teddykoker teddykoker Awaiting requested review from teddykoker

@nateraw nateraw Awaiting requested review from nateraw

@s-rog s-rog Awaiting requested review from s-rog

@yukw777 yukw777 Awaiting requested review from yukw777

+2 more reviewers

@SeanNaren SeanNaren SeanNaren approved these changes

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Borda Borda

Labels

callback feature Is an improvement or enhancement ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.2

Development

Successfully merging this pull request may close these issues.

7 participants

@Borda @pep8speaks @carmocca @SeanNaren @tchaton @justusschock @SkafteNicki