Skip to content

[Feat] Adding PruningCallback#5618

Merged
tchaton merged 34 commits intorelease/1.2-devfrom
feat/pruning
Jan 27, 2021
Merged

[Feat] Adding PruningCallback#5618
tchaton merged 34 commits intorelease/1.2-devfrom
feat/pruning

Conversation

@tchaton
Copy link
Copy Markdown
Contributor

@tchaton tchaton commented Jan 22, 2021 •
edited by carmocca
Loading

What does this PR do?

This PR adds a pruning Callback.

Fixes # (issue) <- this links related issue to this PR

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added this to the 1.2 milestone Jan 22, 2021
@tchaton tchaton self-assigned this Jan 22, 2021
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Jan 22, 2021 •
edited
Loading

Hello @tchaton! Thanks for updating this PR.

Line 138:81: E203 whitespace before ','

Comment last updated at 2021-01-27 01:05:25 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 22, 2021 •
edited
Loading

Codecov Report

Merging #5618 (9caef2e) into release/1.2-dev (7e2e874) will increase coverage by 0%.
The diff coverage is 90%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5618    +/-   ##
================================================
  Coverage               89%     89%            
================================================
  Files                  163     164     +1     
  Lines                12070   12218   +148     
================================================
+ Hits                 10795   10928   +133     
- Misses                1275    1290    +15

ananthsub
ananthsub reviewed Jan 25, 2021
View reviewed changes
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
@tchaton tchaton marked this pull request as ready for review January 25, 2021 10:36
SkafteNicki
SkafteNicki reviewed Jan 25, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a high-level review...
Additional comments:

  • there is an empty file pytorch_lightning/callbacks/pruning_utils/__init__.py that probably can be deleted
  • insert link in the Built-in Callbacks section in the callbacks.rst doc file

Comment thread pytorch_lightning/callbacks/pruning.py Outdated
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
Comment thread pytorch_lightning/callbacks/pruning.py
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
Comment thread pytorch_lightning/callbacks/pruning.py
justusschock
justusschock approved these changes Jan 25, 2021
View reviewed changes
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
Comment thread pytorch_lightning/callbacks/pruning.py
SeanNaren
SeanNaren reviewed Jan 25, 2021
View reviewed changes
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
SeanNaren
SeanNaren reviewed Jan 25, 2021
View reviewed changes
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
SeanNaren
SeanNaren reviewed Jan 25, 2021
View reviewed changes
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
@SeanNaren
Copy link
Copy Markdown
Contributor

SeanNaren commented Jan 25, 2021

Excited to use this :)

SeanNaren
SeanNaren reviewed Jan 25, 2021
View reviewed changes
Comment thread pytorch_lightning/callbacks/pruning.py
SeanNaren
SeanNaren reviewed Jan 25, 2021
View reviewed changes
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
@mergify mergify Bot removed the has conflicts label Jan 26, 2021
@Borda Borda added feature Is an improvement or enhancement design Includes a design discussion labels Jan 26, 2021
Borda
Borda approved these changes Jan 26, 2021
View reviewed changes
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
Comment thread pytorch_lightning/callbacks/pruning.py
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
Comment thread pytorch_lightning/callbacks/pruning.py
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
@Borda Borda requested a review from ananthsub January 26, 2021 13:41
@mergify mergify Bot removed the has conflicts label Jan 26, 2021
karthikprasad
karthikprasad reviewed Jan 26, 2021
View reviewed changes
Comment thread pytorch_lightning/callbacks/pruning.py
karthikprasad
karthikprasad reviewed Jan 26, 2021
View reviewed changes
Comment thread pytorch_lightning/callbacks/pruning.py
z-a-f
z-a-f reviewed Jan 26, 2021
View reviewed changes
Copy link
Copy Markdown

@z-a-f z-a-f left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, less some nits. Will leave it to other to approve

Comment thread pytorch_lightning/callbacks/pruning.py
Comment thread pytorch_lightning/callbacks/pruning.py Outdated
Comment thread tests/callbacks/test_pruning.py
@mergify mergify Bot removed the has conflicts label Jan 26, 2021
@tchaton tchaton enabled auto-merge (squash) January 27, 2021 05:29
@tchaton tchaton merged commit d0aaf98 into release/1.2-dev Jan 27, 2021
@tchaton tchaton deleted the feat/pruning branch January 27, 2021 06:00
@Borda
Copy link
Copy Markdown
Collaborator

Borda commented Jan 29, 2021

btw, https://medium.com/pytorch/pruning-with-catalyst-50e98f2cef2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

@ananthsub ananthsub Awaiting requested review from ananthsub

+3 more reviewers

@karthikprasad karthikprasad karthikprasad left review comments

@z-a-f z-a-f z-a-f left review comments

@SeanNaren SeanNaren SeanNaren approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tchaton tchaton

Labels

design Includes a design discussion feature Is an improvement or enhancement

Projects

None yet

Milestone

pl:1.2

Development

Successfully merging this pull request may close these issues.

9 participants

@tchaton @pep8speaks @SeanNaren @Borda @karthikprasad @ananthsub @z-a-f @justusschock @SkafteNicki