add possibility for nested loaders#5404
Merged
justusschock merged 7 commits intorelease/1.2-devfrom Jan 24, 2021
Merged
Conversation
|
Hello @justusschock! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-24 10:45:49 UTC |
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5404 +/- ##
===============================================
- Coverage 92% 92% -0%
===============================================
Files 153 153
Lines 10834 10840 +6
===============================================
Hits 10011 10011
- Misses 823 829 +6 |
awaelchli
approved these changes
Jan 8, 2021
SkafteNicki
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extends #1959 to the possibility of nested loaders as mentioned by @tchaton in #1959 (comment)
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
Ps: Sorry for the formatting, this happens automatically on import in my IDE. Hope this isn't an issue in this small PR.