Skip to content

Fix invalid value for weights_summary#5296

Merged
rohitgr7 merged 7 commits intomasterfrom
bugfix/model_sum
Jan 5, 2021
Merged

Fix invalid value for weights_summary#5296
rohitgr7 merged 7 commits intomasterfrom
bugfix/model_sum

Conversation

@rohitgr7
Copy link
Copy Markdown
Contributor

@rohitgr7 rohitgr7 commented Dec 29, 2020

What does this PR do?

The main fix here is if you do model.summarize(None) it still prints the total params, trainable params, ... and if you do model.summarize('invalid_string or value') it won't raise an error and will act like None.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes [if needed]?
  • Did you write any new necessary tests [no need for typos, docs]?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 added the bug Something isn't working label Dec 29, 2020
@rohitgr7 rohitgr7 added this to the 1.1.x milestone Dec 29, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 29, 2020 •
edited
Loading

Codecov Report

Merging #5296 (03f8684) into master (15a400b) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5296   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9950    9954    +4     
======================================
+ Hits         9261    9266    +5     
+ Misses        689     688    -1

@rohitgr7 rohitgr7 marked this pull request as ready for review December 30, 2020 11:49
@rohitgr7 rohitgr7 requested review from carmocca and s-rog December 30, 2020 11:50
@Borda Borda modified the milestones: 1.1.x, 1.2 Dec 31, 2020
@Borda Borda added the design Includes a design discussion label Dec 31, 2020
@Borda Borda changed the base branch from master to release/1.2-dev December 31, 2020 08:15
@Borda
Copy link
Copy Markdown
Collaborator

Borda commented Dec 31, 2020

@rohitgr7 as you are changing API we need to move it to 1.2
mind rebase on feature 1.2 🐰

@rohitgr7
Copy link
Copy Markdown
Contributor Author

rohitgr7 commented Dec 31, 2020

I thought I created this branch on top of release branch only. Will update it.

carmocca
carmocca approved these changes Jan 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One thing:

Why not keep mode to avoid the API change?

@awaelchli
Copy link
Copy Markdown
Contributor

awaelchli commented Jan 2, 2021

+1 for keeping mode please :)

@rohitgr7
Copy link
Copy Markdown
Contributor Author

rohitgr7 commented Jan 2, 2021 •
edited
Loading

I did that to have the exception at one place for both the cases.

trainer = Trainer(weights_summary='sdf')
model.summarize(weights_summary='sdf')

Will update this then.

@rohitgr7 rohitgr7 changed the base branch from release/1.2-dev to master January 2, 2021 14:34
@rohitgr7 rohitgr7 requested a review from carmocca January 2, 2021 14:35
@Borda Borda removed the design Includes a design discussion label Jan 2, 2021
@Borda
Copy link
Copy Markdown
Collaborator

Borda commented Jan 2, 2021

@rohitgr7 is it as a bugfix for master or a feature for 1.2? there is some confusion as it is a 1.2 milestone but the target is master

@rohitgr7 rohitgr7 modified the milestones: 1.2, 1.1.x Jan 2, 2021
@rohitgr7
Copy link
Copy Markdown
Contributor Author

rohitgr7 commented Jan 2, 2021

bugfix now. forgot to update the milestone. Updated!

@carmocca
Copy link
Copy Markdown
Contributor

carmocca commented Jan 2, 2021 •
edited
Loading

I did that to have the exception at one place for both the cases.

Didn't realize the API was inconsistent. I like what you propose. We can do it in another PR

awaelchli
awaelchli approved these changes Jan 3, 2021
View reviewed changes
Comment thread pytorch_lightning/core/lightning.py Outdated
@rohitgr7 rohitgr7 enabled auto-merge (squash) January 4, 2021 19:25
@Borda Borda added the ready to be merged PRs ready to be merged label Jan 4, 2021
@rohitgr7 rohitgr7 merged commit 062800a into master Jan 5, 2021
@rohitgr7 rohitgr7 deleted the bugfix/model_sum branch January 5, 2021 07:43
Borda pushed a commit that referenced this pull request Jan 6, 2021
@rohitgr7 @Borda
Fix invalid value for weights_summary (#5296)
704e00e 
* Fix weights_summary

* use mode

* fix

* optional

* what was I thinking

(cherry picked from commit 062800a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@Borda Borda Awaiting requested review from Borda

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@s-rog s-rog Awaiting requested review from s-rog

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@edenlightning edenlightning Awaiting requested review from edenlightning

@teddykoker teddykoker Awaiting requested review from teddykoker

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.1.x

Development

Successfully merging this pull request may close these issues.

5 participants

@rohitgr7 @Borda @awaelchli @carmocca @tchaton