This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Swav#239
Merged
ananyahjha93 merged 55 commits intomasterfrom Oct 19, 2020
Merged
Conversation
|
Hello @ananyahjha93! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-19 16:09:54 UTC |
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 83.91% 82.06% -1.86%
==========================================
Files 91 97 +6
Lines 4861 5441 +580
==========================================
+ Hits 4079 4465 +386
- Misses 782 976 +194
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Borda
reviewed
Sep 16, 2020
Borda
reviewed
Sep 17, 2020
edgarriba
reviewed
Oct 19, 2020
|
|
||
| if prob < self.p: | ||
| sigma = (self.max - self.min) * np.random.random_sample() + self.min | ||
| sample = cv2.GaussianBlur(sample, (self.kernel_size, self.kernel_size), sigma) |
There was a problem hiding this comment.
teddykoker
reviewed
Oct 19, 2020
| ) | ||
|
|
||
| trainer = pl.Trainer( | ||
| gpus=0, fast_dev_run=False, max_epochs=1, default_root_dir=tmpdir, max_steps=3 |
Contributor
There was a problem hiding this comment.
Can we at least do a fast_dev_run to test?
Borda
reviewed
Oct 19, 2020
teddykoker
reviewed
Oct 19, 2020
|
|
||
| class GaussianBlur(object): | ||
| # Implements Gaussian blur as described in the SimCLR paper | ||
| def __init__(self, kernel_size, p=0.5, min=0.1, max=2.0): |
Contributor
There was a problem hiding this comment.
Might not want to use min and max since these are Python built-ins. Could lead to potential issues.
teddykoker
approved these changes
Oct 19, 2020
Borda
reviewed
Oct 19, 2020
| @@ -1,2 +1,2 @@ | |||
| pytorch-lightning>=1.0 | |||
Member
There was a problem hiding this comment.
reverse order
torch>=1.6
pytorch-lightning>=1.0
nateraw
approved these changes
Oct 19, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Adapts swav from official implementation.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃