B027 now ignores @[anything].overload to reduce false positives.#309
Merged
cooperlees merged 1 commit intoPyCQA:mainfrom Nov 7, 2022
Merged
B027 now ignores @[anything].overload to reduce false positives.#309cooperlees merged 1 commit intoPyCQA:mainfrom
cooperlees merged 1 commit intoPyCQA:mainfrom
Conversation
cooperlees
approved these changes
Nov 7, 2022
Collaborator
cooperlees
left a comment
There was a problem hiding this comment.
Agree it's better to be less nosy here. Thanks for adding the tests too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304
it also ignores
@a.b.c.d.overloadin case somebody is writing a custom overload or importing typing in some very weird way - but that seems more likely than disaster striking because the check didn't trigger imo. Didn't bother writing a test for that though