EHN: also raise B006 for list/dict/set comprehensions#186
Merged
cooperlees merged 4 commits intoPyCQA:masterfrom Sep 28, 2021
Merged
EHN: also raise B006 for list/dict/set comprehensions#186cooperlees merged 4 commits intoPyCQA:masterfrom
cooperlees merged 4 commits intoPyCQA:masterfrom
Conversation
Contributor
Author
|
oh bloody hell, there's AST differences on Python 3.7 and below >.< |
isidentical
reviewed
Sep 16, 2021
| ) | ||
| ) | ||
| B006.mutable_literals = (ast.Dict, ast.List, ast.Set) | ||
| B006.mutable_comprehensions = (ast.ListComp, ast.DictComp) |
Contributor
There was a problem hiding this comment.
I think set comprehensions ({x for x in y}) is also suitable in this context
Suggested change
| B006.mutable_comprehensions = (ast.ListComp, ast.DictComp) | |
| B006.mutable_comprehensions = (ast.ListComp, ast.DictComp, ast.SetComp) |
Contributor
Author
There was a problem hiding this comment.
And I knew I was forgetting something, thanks for noticing I'll fix it soon once I get back to my computer at home.
cooperlees
approved these changes
Sep 28, 2021
Collaborator
cooperlees
left a comment
There was a problem hiding this comment.
LGTM - Thanks Mr @ichard26 :D
| B006(70, 32), | ||
| B008(98, 29), | ||
| B008(102, 44), | ||
| B006(124, 45 if sys.version_info >= (3, 8) else 46), |
Collaborator
There was a problem hiding this comment.
Yeah, I agree lets only care for newer versions ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-184.