Merged
Conversation
WP 5.9 contains polyfills for five new PHP native functions: * `array_key_first()` and `array_key_last()`, which were both introduced in PHP 7.3. * `str_contains()`, `str_starts_with()` and `str_ends_with()`, which were introduced in PHP 8.0. While the PHP 8.0 functions are not yet flagged by the latest release of PHPCompatibility, they will be once PHPCompatibility 10.0 comes out. As `exclude`-ing error codes which don't exist yet does not lead to errors in PHPCS, we may as well add the exclusions for all WP 5.9 polyfills in one go. Refs: * https://core.trac.wordpress.org/changeset/52038 * https://core.trac.wordpress.org/changeset/52039 * https://core.trac.wordpress.org/changeset/52040 * https://core.trac.wordpress.org/browser/trunk/src/wp-includes/compat.php#L398-L479
GaryJones
approved these changes
Dec 30, 2021
wimg
approved these changes
Dec 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WP 5.9 contains polyfills for five new PHP native functions:
array_key_first()andarray_key_last(), which were both introduced in PHP 7.3.str_contains(),str_starts_with()andstr_ends_with(), which were introduced in PHP 8.0.While the PHP 8.0 functions are not yet flagged by the latest release of PHPCompatibility, they will be once PHPCompatibility 10.0 comes out.
As
exclude-ing error codes which don't exist yet does not lead to errors in PHPCS, we may as well add the exclusions for all WP 5.9 polyfills in one go.Refs: