Merged
Conversation
4a012e0 to
e4decaf
Compare
> Intl: > The default parameter value of idn_to_ascii() and idn_to_utf8() is now > INTL_IDNA_VARIANT_UTS46 instead of the deprecated INTL_IDNA_VARIANT_2003. **Note**: The new sniff will only throw an error when the `testVersion` indicates that both PHP < 7.4 as well as PHP 7.4+ need to be supported. There is a risk in that, i.e. when people use PHPCompatibility against their code using only their current server version, `7.2`, and when upgrading the server version, only the new version, `7.4`, they will not be shown this message in either run. The other side of that coin is that it prevents unnecessary errors/warnings for code which only needs to support one PHP version and is therefore not directly affected by this change. This should possibly be addressed in the `Readme` by advising people to use a `testVersion` spanning both the old and the new server version, `7.2-7.4` when they are testing if their server can safely be upgraded. Refs: * https://github.com/php/php-src/blob/86d751f696786bcb95c580482c9884e41ccf2406/UPGRADING#L66-L68 * https://wiki.php.net/rfc/deprecate-and-remove-intl_idna_variant_2003 * https://www.php.net/manual/en/function.idn-to-ascii.php * https://www.php.net/manual/en/function.idn-to-utf8.php * php/php-src@01912f9
e4decaf to
4123e3d
Compare
wimg
approved these changes
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: The new sniff will only throw an error when the
testVersionindicates that both PHP < 7.4 as well as PHP 7.4+ need to be supported.There is a risk in that, i.e. when people use PHPCompatibility against their code using only their current server version,
7.2, and when upgrading the server version, only the new version,7.4, they will not be shown this message in either run.The other side of that coin is that it prevents unnecessary errors/warnings for code which only needs to support one PHP version and is therefore not directly affected by this change.
This should possibly be addressed in the
Readmeby advising people to use atestVersionspanning both the old and the new server version,7.2-7.4when they are testing if their server can safely be upgraded.Refs:
Related to #808