Merged
Conversation
Constants in PHP are namespaced as well, however, when PHP cannot find the constant in the namespace, it will fall through to the global namespace. The step to first check within the namespace can be skipped by either using `use const ...` (PHP 5.6+) or by prefixing the constant with a `\`. As PHPCompatibility uses a lot of global constants, some performance gain can be archived by using the FQN for constants. This PR implements this throughout the codebase. If we want to guard this for the future, we could add the SlevomatCodingStandard as a `dev` dependency and add the `SlevomatCodingStandard.Namespaces.FullyQualifiedGlobalConstants` sniff to the PHPCompatibility native ruleset.
wimg
approved these changes
Dec 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As there are no sniff PRs open at the moment, this felt like as good a time as any to make this change ;-)
Constants in PHP are namespaced as well, however, when PHP cannot find the constant in the namespace, it will fall through to the global namespace.
The step to first check within the namespace can be skipped by either using
use const ...(PHP 5.6+) or by prefixing the constant with a\.As PHPCompatibility uses a lot of global constants, some performance gain can be archived by using the FQN for constants.
This PR implements this throughout the codebase.
If we want to guard this for the future, we could add the SlevomatCodingStandard as a
devdependency and add theSlevomatCodingStandard.Namespaces.FullyQualifiedGlobalConstantssniff to the PHPCompatibility native ruleset.