Conversation
Most error messages in PHPCompatibility follow one of the below formats: * "Feature x is not supported in PHP x.x and below" (new features) * "Feature x was deprecated in PHP x.x and removed in PHP x.x" (removed features) The error message for short array syntax did not follow that typical pattern and was confusing to some - I've recently had questions about it from a few different people -, so I'm proposing to adjust the error message to be more in line with other messages in the PHPCompatibility library.
…prove-error-msg NewShortArray: improve error message
As [PHP 7.4 has been released](https://www.php.net/archive/2019.php#2019-11-28-1), the build against PHP 7.4 should no longer be allowed to fail. Includes some tweaking of the matrix to have the coverage stage and the quick test stage include PHP 7.4.
…ot-allowed-to-fail Travis: don't allow PHP 7.4 build to fail
…ainst-7.4 Travis: test against PHP 7.4, not snapshot
* Improve short descriptions. * Where relevant, add long descriptions with more details about the PHP change and how the sniff handles it. * Add _PHP version x.x_ annotations. * Add `@link` tags to the relevant PHP documentation which led to the sniff. And make sure these are in a consistent order as per above.
The base URL for the php.net manual site has changed.
... for non-class based files.
…blocks Includes annotating significant changes to methods/properties. Based on trace-back through the file history. Note: this is only done for the sniff related files and for method in abstract classes, not for the sniff test files which are not user-facing.
The two new PHP 7.4 classes had inadvertently been added to the `$newExceptions` array, while they should have been added to the `$newClasses` aray.
Don't use double quotes when they're not needed.
…ass-descriptions Documentation: improve sniff class descriptions
…st-class-descriptions Documentation: simplify & sync the sniff test class descriptions
…ility-test-class-descriptions Documentation: improve the utility test class descriptions
…pdate-ref-url NewInterfaces: update reference URLs
…ocks-since-tags Documentation: add @SInCE tags to file docblocks
…ocblocks-add-since-tags Documentation: add `@since` tags to method, property and constant docblocks
…incorrectly-placed-classes NewClasses: minor bug fix - move two classes
CS: minor tweaks
For the use of `@internal` tags with comments for dev internal information, it used to be recommended to use `{@internal ... }}` (not the double curlies at the end) format to help IDEs parse these correctly.
This format has since been superseded as the parsing of docblocks in IDEs has improved a lot since then.
The current recommendation is to just use a single curly at the end.
Ref: https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#55-internal
... for the purposes of line end detection.
…on-detection PHP 7.4: Add detection of features from the new FFI extension detection
…e-internal-tag Documentation: improve use of `@internal` tags
Documentation: various minor tweaks
…butes .gitattributes: treat the test case files same as PHP files
Includes all merged & currently open PRs. Release date tentatively set at Friday December 27.
Changelog for PHPCompatibility 9.3.5
Member
Author
|
Release tweet: https://twitter.com/jrf_nl/status/1210503716048134144 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for tracking changes for the 9.3.5 release. Target release date: Friday December 27.
master(careful, GH defaults todevelop!) & copy & paste the changelog to itOpen PR to mergemasterintodevelopto get rid of the This branch is out-of-date with the base branch messages on each release. (only after major releases)