Conversation
As `develop` is now the default branch, the conditions based on which the various build stages are being triggered need to be updated, otherwise, builds will only run the `sniff` stage for pull requests against `develop`.
... picked up along the way.
This changes all file docblocks to align with the proposal made in issue 734. Any pertinent information which was in the file docblock and wasn't already mentioned elsewhere has been moved to the class docblock.
Note: only the docblocks for user-facing code contain `@since` tags.
…tation-fixes Various minor documentation fixes
…g-exception-throws-tags Documentation: add missing @throws tags
…ernal-tags Documentation: fix up some @internal tags
…ect-return-type Documentation: fix incorrect @return type
…erty-var-types Documentation: fix incorrect property @var tag types
…ocblocks Documentation: fix up all file docblocks
…g-const-docblocks Documentation: add docblocks to class constants
Bugs: 1. "Empty" tokens (whitespace, comments) were not disregarded when determining whether the first parameter was only a text string, which could lead to the second parameter being examined when it doesn't need to be. 2. If either parameter contained a ternary, potentially nested in some other construct, the ternary would confuse the sniff. Both fixed now. In addition to this if one of the parameters contains an `(array)` cast, let's presume that's the array parameter. This may lead to some false positives for complexly build parameters, but we'll deal with that later if needs be. Includes unit tests. Fixes 890
…er-bug RemovedImplodeFlexibleParamOrder: fix two bugs + one enhancement
…r-develop-branch Travis: update stage conditions
Changelog for PHPCompatibility 9.3.1
wimg
approved these changes
Sep 5, 2019
Member
Author
|
Release tweet: https://twitter.com/jrf_nl/status/1169683515727929345 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for tracking changes for the 9.3.1 release. Target release date: Friday September 6.
master(careful, GH defaults todevelop!) & copy & paste the changelog to itOpen PR to mergemasterintodevelopto get rid of the This branch is out-of-date with the base branch messages on each release. (only after major releases)