ObjectReflectionCache - Skip property-reflection for IFormattable#3434
Merged
304NotModified merged 1 commit intoNLog:release/4.6.4from May 26, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## release/4.6.4 #3434 +/- ##
==============================================
- Coverage 80% 80% -<1%
==============================================
Files 358 358
Lines 28516 28514 -2
Branches 3814 3813 -1
==============================================
- Hits 22846 22825 -21
- Misses 4569 4589 +20
+ Partials 1101 1100 -1 |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid serializing JSON.NET
JValue-properties when it contains a non-primitive object (Ex. like TimeSpan).