Update package descriptions to note the issues with <PackageReference>#3393
Merged
304NotModified merged 1 commit intorelease/4.6.4from May 13, 2019
Merged
Update package descriptions to note the issues with <PackageReference>#3393304NotModified merged 1 commit intorelease/4.6.4from
304NotModified merged 1 commit intorelease/4.6.4from
Conversation
Codecov Report
@@ Coverage Diff @@
## release/4.6.4 #3393 +/- ##
==============================================
- Coverage 80% 80% -<1%
==============================================
Files 357 357
Lines 28247 28297 +50
Branches 3758 3766 +8
==============================================
+ Hits 22616 22642 +26
- Misses 4541 4550 +9
- Partials 1090 1105 +15 |
Contributor
|
Maybe just redirect to the tutorial: https://github.com/NLog/NLog/wiki/Tutorial Instead the heavy documents: https://github.com/NLog/NLog/wiki/Configuration-file |
Member
Author
|
Good point, but IMO the tutorial is on too high level and also references the nlog config package... |
Contributor
|
Maybe the tutorial should not give high recommendation for using NLog.config, but just mention that it exists (and that NLog.config-package only works sometimes, and other times can be a world of hurt). People deciding whether to use the NLog.config-package are most likely looking for a high-level-introduction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3390