Skip to content

Log4JXmlEventLayout - Added support for configuration of Parameters#3389

Merged
304NotModified merged 1 commit intoNLog:release/4.6.4from
snakefoot:Log4JXmlEventLayoutParameters
May 12, 2019
Merged

Log4JXmlEventLayout - Added support for configuration of Parameters#3389
304NotModified merged 1 commit intoNLog:release/4.6.4from
snakefoot:Log4JXmlEventLayoutParameters

Conversation

@snakefoot
Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 11, 2019

Codecov Report

Merging #3389 into master will increase coverage by <1%.
The diff coverage is 69%.

@@           Coverage Diff           @@
##           master   #3389    +/-   ##
=======================================
+ Coverage      80%     80%   +<1%     
=======================================
  Files         356     356            
  Lines       28205   28212     +7     
  Branches     3750    3753     +3     
=======================================
+ Hits        22559   22607    +48     
+ Misses       4540    4512    -28     
+ Partials     1106    1093    -13

@snakefoot snakefoot force-pushed the Log4JXmlEventLayoutParameters branch from af0ace9 to c05cd95 Compare May 11, 2019 22:16
@snakefoot
Copy link
Copy Markdown
Contributor Author

@304NotModified Can also be included for NLog 4.6.4

@304NotModified 304NotModified changed the base branch from dev to master May 12, 2019 16:59
@304NotModified 304NotModified changed the base branch from master to dev May 12, 2019 16:59
@304NotModified
Copy link
Copy Markdown
Member

Ok! Could you please rebase it on master and change the PR's base afterwards? Thanks!

@snakefoot snakefoot force-pushed the Log4JXmlEventLayoutParameters branch from c05cd95 to 36e7ee8 Compare May 12, 2019 19:13
@snakefoot snakefoot changed the base branch from dev to master May 12, 2019 19:13
@snakefoot snakefoot force-pushed the Log4JXmlEventLayoutParameters branch from 36e7ee8 to f6c7f86 Compare May 12, 2019 19:14
@snakefoot
Copy link
Copy Markdown
Contributor Author

@304NotModified Changed base to master

@304NotModified 304NotModified changed the base branch from master to release/4.6.4 May 12, 2019 20:36
@304NotModified
Copy link
Copy Markdown
Member

great work! thanks!

I will merge it first to an intermediate release branch (so I won't break the debug symbols of 4.6.3)

@304NotModified 304NotModified merged commit df1122a into NLog:release/4.6.4 May 12, 2019
@304NotModified 304NotModified added this to the 4.6.4 milestone May 12, 2019
@snakefoot snakefoot deleted the Log4JXmlEventLayoutParameters branch April 4, 2020 12:55
@snakefoot snakefoot added the log4jxml-layout Log4j XML Layout label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants