LogFactory - GetLogger should null-check logger name#3332
Merged
304NotModified merged 1 commit intoNLog:devfrom Apr 24, 2019
Merged
LogFactory - GetLogger should null-check logger name#3332304NotModified merged 1 commit intoNLog:devfrom
304NotModified merged 1 commit intoNLog:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #3332 +/- ##
======================================
+ Coverage 80% 80% +<1%
======================================
Files 356 356
Lines 28101 28103 +2
Branches 3743 3744 +1
======================================
+ Hits 22517 22535 +18
+ Misses 4503 4486 -17
- Partials 1081 1082 +1 |
Member
|
Thanks! |
Member
Doubted also about this, but I think the change in this PR is good enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throw
ArgumentNullExceptioninstead of throwingNullReferenceExceptionhere (When Name is null):NLog/src/NLog/LogFactory.cs
Line 1015 in 3c16e69
Could also consider doing fallback to string.Empty.