Make HttpNetworkSender mockable, add unit test, introduce NSubsitute#3274
Merged
304NotModified merged 3 commits intodevfrom Apr 4, 2019
Merged
Make HttpNetworkSender mockable, add unit test, introduce NSubsitute#3274304NotModified merged 3 commits intodevfrom
304NotModified merged 3 commits intodevfrom
Conversation
66b21f8 to
7a9732b
Compare
2462bce to
8eebe43
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3274 +/- ##
=======================================
+ Coverage 80% 81% +1%
=======================================
Files 355 356 +1
Lines 27999 29623 +1624
Branches 3728 4321 +593
=======================================
+ Hits 22327 23990 +1663
+ Misses 4599 4570 -29
+ Partials 1073 1063 -10 |
Member
Author
|
looks too good to be true:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3181
todo