Codecov Report

Merging #3335 into dev will increase coverage by <1%.
The diff coverage is 42%.

@@          Coverage Diff           @@
##             dev   #3335    +/-   ##
======================================
+ Coverage     80%     80%   +<1%     
======================================
  Files        356     356            
  Lines      28226   28222     -4     
  Branches    3763    3762     -1     
======================================
+ Hits       22579   22586     +7     
+ Misses      4558    4549     -9     
+ Partials    1089    1087     -2

Hi, thanks for the PR,

but would it be more logical to have something like this:

LogManager.ReloadConfiguration();
// and/or
LogFactory.ReloadConfiguration();

I find the "active" a bit unusual

I find the "active" a bit unusual

I need a method on LoggingConfiguraion (or method that takes LoggingConfiguration as parameter), that allows one to reload the config with respect to KeepVariablesOnReload (For use in NLog.Extension.Logging).

But also thought it would be nice to provide a solution for #3304

But maybe I should just remove the new introduced method completely. Since I can probably implement this variable copy manually in NLog.Extension.Logging.

But maybe I should just remove the new introduced method completely. Since I can probably implement this variable copy manually in NLog.Extension.Logging.

I'm also doubting this addition makes things easier, so for now I think

 NLog.LogManager.Configuration = NLog.LogManager.Configuration.Reload();

Is good enough

Is good enough

But it will not support KeepVariablesOnReload

but would it be more logical to have something like this:

LogManager.ReloadConfiguration();
// and/or
LogFactory.ReloadConfiguration();

Can't be do newConfig.CopyVariables(currentConfig.Variables); in e.g. the LogManager to arrange this?

in e.g. the LogManager to arrange this?

Sounds like something for NLog 5.0. Lets just rollback #3306

I'm confused. You forced pushed different content? Won't it be more logical to close the old PR and create a new one?

Hate to waste a precious PulRequest-number :)

This is still valid, isn't?