Add implementation of dependency metric collection for Livemetrics#883
Merged
Conversation
littleaj
approved these changes
Mar 28, 2019
littleaj
left a comment
Contributor
There was a problem hiding this comment.
If there's a test for the other measurements, let's include this one too. Other than that, it looks good.
Contributor
Author
Nope there is apparently no test for QuickPulse codebase. This is far from ideal solution. Currently, this is to just unblock a major bug. When we get to phase for live metrics v2, we will invest in testability of this area (If done in SDK). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #882