Skip to content

Fix shutdown issue due to non-daemon thread#1245

Merged
trask merged 1 commit into
masterfrom
trask/fix-shutdown-issue
May 26, 2020
Merged

Fix shutdown issue due to non-daemon thread#1245
trask merged 1 commit into
masterfrom
trask/fix-shutdown-issue

Conversation

@trask

@trask trask commented May 24, 2020

Copy link
Copy Markdown
Member

For short-running applications that never perform a GC, this non-daemon thread used during startup is never collected and prevents normal termination at the end of the main method.

@trask trask marked this pull request as ready for review May 24, 2020 00:16
@trask trask force-pushed the trask/fix-shutdown-issue branch from 849895c to 8ad7d5d Compare May 24, 2020 00:20

@littleaj littleaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

@trask trask merged commit bd323f0 into master May 26, 2020
@trask trask deleted the trask/fix-shutdown-issue branch May 26, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants