Allow prerelease versions in release headers#130
Merged
Conversation
Currently, this tool expects the version in a release header to be a version that looks like `<major>.<minor>.<patch>` and rejects other formats. However, it may be useful to publish a prerelease version of a package so that integration with other products/services can be tested in a more "live" manner, particularly if that package is a part of a monorepo. A prerelease version looks like `<major>.<minor>.<patch>-<prerelease identifier>.<number>`, where `<prerelease identifier>` can be an arbitrary word like `alpha`, `beta`, or `rc`. This commit allows such versions.
Contributor
Author
|
This commit should hopefully fix the CI errors we're seeing here: https://github.com/MetaMask/controllers/actions/runs/3473161747/jobs/5804878754#step:6:14 |
FrederikBolding
approved these changes
Nov 15, 2022
Merged
legobeat
pushed a commit
to legobeat/auto-changelog
that referenced
this pull request
Dec 13, 2022
Currently, this tool expects the version in a release header to be a version that looks like `<major>.<minor>.<patch>` and rejects other formats. However, it may be useful to publish a prerelease version of a package so that integration with other products/services can be tested in a more "live" manner, particularly if that package is a part of a monorepo. A prerelease version looks like `<major>.<minor>.<patch>-<prerelease identifier>.<number>`, where `<prerelease identifier>` can be an arbitrary word like `alpha`, `beta`, or `rc`. This commit allows such versions.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, this tool expects the version in a release header to be a version that looks like
<major>.<minor>.<patch>and rejects other formats. However, it may be useful to publish a prerelease version of a package so that integration with other products/services can be tested in a more "live" manner, particularly if that package is a part of a monorepo. A prerelease version looks like<major>.<minor>.<patch>-<prerelease identifier>.<number>, where<prerelease identifier>can be an arbitrary word likealpha,beta, orrc. This commit allows such versions.