Skip to content

Parsing error occurs when POST response is empty gzip content type#350

Merged
ryber merged 4 commits into
Kong:masterfrom
sthamman:null-response
Apr 11, 2020
Merged

Parsing error occurs when POST response is empty gzip content type#350
ryber merged 4 commits into
Kong:masterfrom
sthamman:null-response

Conversation

@sthamman

Copy link
Copy Markdown

Fixes #349

@sthamman sthamman marked this pull request as ready for review April 11, 2020 07:44

@ryber ryber left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for addressing this issue! I do have a few thoughts before merging.

Comment thread unirest/src/main/java/kong/unirest/apache/ApacheResponse.java Outdated
Comment thread unirest/src/test/java/BehaviorTests/GZipTest.java Outdated

@ryber ryber left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks!

@ryber ryber merged commit ddac108 into Kong:master Apr 11, 2020
@ryber

ryber commented Apr 11, 2020

Copy link
Copy Markdown
Collaborator

I have a couple other small things I'll cut a patch version later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parsing error occurs when POST response is empty gzip content type

2 participants