Headers: add toString() for nicer logging/debugging#321
Merged
Conversation
ryber
approved these changes
Nov 28, 2019
ryber
left a comment
Collaborator
There was a problem hiding this comment.
Hi @hilmarf, thank you for the contribution, I fully endorse this and I was planning on getting a new release out this morning so I will add it to that. One node for the future. We generally expect tests for all changes. Since this is a pretty safe change so I'll merge it. but next time if you have anything that might have a bigger impact on existing functionality you will want to have unit and behavioral tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nobody is interested in seeing things like:
kong.unirest.Headers@4dffff9or
[kong.unirest.Headers$Entry@2904bc56, kong.unirest.Headers$Entry@7bb25046, kong.unirest.Headers$Entry@69b1e8f8]Let's improve this.
Thanks,
Hilmar