Skip to content

TraceView: Add option to show P2P relation when a project is highlighted#628

Merged
KirillOsenkov merged 6 commits intoKirillOsenkov:mainfrom
yuehuang010:main
Nov 6, 2022
Merged

TraceView: Add option to show P2P relation when a project is highlighted#628
KirillOsenkov merged 6 commits intoKirillOsenkov:mainfrom
yuehuang010:main

Conversation

@yuehuang010
Copy link
Copy Markdown
Contributor

@yuehuang010 yuehuang010 commented Nov 5, 2022

Add a feature to show P2P relationship when a project node is selected.

  • Remove some common P2P targets to avoid clutter. ~10% of total targets, but huge visual real estate because they are long running.
  • To compensate for the loss of details, extend highlight to show parent and dependent projects.
  • Refactor Highlight mechanic to an single overlay Canvas.
  • Removed ContentControl() to speed up loading. Est. ~10% faster.
  • Moved some context menu into sub-menu as the menu is starting to get long.
  • As part of the refactor, improved hit rate of GoToTimedNode() by reloading all TextBlocks.

Misc.

  • Avoid failing to load C++ Analysis when a duplicated message is printed. Not sure why such message is printed, but best not to fail.
After
Before

Copy link
Copy Markdown
Owner

@KirillOsenkov KirillOsenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@KirillOsenkov KirillOsenkov merged commit 1d3c6d1 into KirillOsenkov:main Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants